From e812a31c4006b86f9fa72a768d49fa263e2440f8 Mon Sep 17 00:00:00 2001 From: Albert Vaca Cintora Date: Mon, 22 Jul 2019 22:48:06 +0200 Subject: [PATCH] Remove the need to use qt5_wrap_cpp for moc generation --- declarativeplugin/CMakeLists.txt | 7 +---- declarativeplugin/objectfactory.cpp | 36 ++++++++++++++++++++++ declarativeplugin/objectfactory.h | 46 ++++++++++++++++++----------- 3 files changed, 65 insertions(+), 24 deletions(-) create mode 100644 declarativeplugin/objectfactory.cpp diff --git a/declarativeplugin/CMakeLists.txt b/declarativeplugin/CMakeLists.txt index 0e1244708..6f119d7b8 100644 --- a/declarativeplugin/CMakeLists.txt +++ b/declarativeplugin/CMakeLists.txt @@ -6,6 +6,7 @@ include_directories(${CMAKE_CURRENT_BINARY_DIR} set(kdeconnectdeclarativeplugin_SRC kdeconnectdeclarativeplugin.cpp responsewaiter.cpp + objectfactory.cpp ) set(qml_SRC @@ -14,12 +15,6 @@ set(qml_SRC qml/DBusProperty.qml ) -set(kdeconnectdeclarativeplugin_MOC - objectfactory.h -) - -qt5_wrap_cpp(kdeconnectdeclarativeplugin_SRC ${kdeconnectdeclarativeplugin_MOC}) - add_library(kdeconnectdeclarativeplugin SHARED ${kdeconnectdeclarativeplugin_SRC}) target_link_libraries(kdeconnectdeclarativeplugin Qt5::Qml diff --git a/declarativeplugin/objectfactory.cpp b/declarativeplugin/objectfactory.cpp new file mode 100644 index 000000000..aef16c9d4 --- /dev/null +++ b/declarativeplugin/objectfactory.cpp @@ -0,0 +1,36 @@ +/** + * Copyright 2013 Albert Vaca + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License or (at your option) version 3 or any later version + * accepted by the membership of KDE e.V. (or its successor approved + * by the membership of KDE e.V.), which shall act as a proxy + * defined in Section 14 of version 3 of the license. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + +#include "objectfactory.h" + +QObject* ObjectFactory::create() { + if (m_f0) return m_f0(); + return nullptr; +} + +QObject* ObjectFactory::create(const QVariant& arg1) { + if (m_f1) return m_f1(arg1); + return nullptr; +} + +QObject* ObjectFactory::create(const QVariant& arg1, const QVariant& arg2) { + if (m_f2) return m_f2(arg1, arg2); + return nullptr; +} diff --git a/declarativeplugin/objectfactory.h b/declarativeplugin/objectfactory.h index bb5974411..7c4f4aaa2 100644 --- a/declarativeplugin/objectfactory.h +++ b/declarativeplugin/objectfactory.h @@ -1,3 +1,23 @@ +/** + * Copyright 2013 Albert Vaca + * + * This program is free software; you can redistribute it and/or + * modify it under the terms of the GNU General Public License as + * published by the Free Software Foundation; either version 2 of + * the License or (at your option) version 3 or any later version + * accepted by the membership of KDE e.V. (or its successor approved + * by the membership of KDE e.V.), which shall act as a proxy + * defined in Section 14 of version 3 of the license. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY; without even the implied warranty of + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the + * GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program. If not, see . + */ + #ifndef QOBJECT_FACTORY_H #define QOBJECT_FACTORY_H @@ -9,33 +29,23 @@ class ObjectFactory : public QObject { Q_OBJECT - + typedef QObject* (*Func0)(); typedef QObject* (*Func1)(const QVariant&); typedef QObject* (*Func2)(const QVariant&, const QVariant&); - + public: ObjectFactory(QObject* parent, Func0 f0) : QObject(parent), m_f0(f0), m_f1(nullptr), m_f2(nullptr) {} ObjectFactory(QObject* parent, Func1 f1) : QObject(parent), m_f0(nullptr), m_f1(f1), m_f2(nullptr) {} ObjectFactory(QObject* parent, Func2 f2) : QObject(parent), m_f0(nullptr), m_f1(nullptr), m_f2(f2) {} - + ~ObjectFactory() override = default; - Q_INVOKABLE QObject* create() { - if (m_f0) return m_f0(); - return nullptr; - } - - Q_INVOKABLE QObject* create(const QVariant& arg1) { - if (m_f1) return m_f1(arg1); - return nullptr; - } - - Q_INVOKABLE QObject* create(const QVariant& arg1, const QVariant& arg2) { - if (m_f2) return m_f2(arg1, arg2); - return nullptr; - } - + Q_INVOKABLE QObject* create(); + Q_INVOKABLE QObject* create(const QVariant& arg1); + + Q_INVOKABLE QObject* create(const QVariant& arg1, const QVariant& arg2); + private: Func0 m_f0; Func1 m_f1;