Fix really terrible code

This commit is contained in:
Albert Vaca Cintora 2023-05-25 13:08:10 +02:00
parent 146b2d62e0
commit e53e7bc600

View file

@ -409,14 +409,12 @@ bool SystemvolumePlugin::receivePacket(const NetworkPacket &np)
} else { } else {
QString name = np.get<QString>(QStringLiteral("name")); QString name = np.get<QString>(QStringLiteral("name"));
if (sinkList.contains(name)) { auto sinkListIterator = this->sinkList.find(name);
// unregister ControlChangeNotify before doing any changes to a sink if (sinkListIterator != this->sinkList.end()) {
HRESULT unregisterSuccess = E_POINTER;
auto sinkListIterator = this->sinkList.find(name);
auto &sink = sinkListIterator.value(); auto &sink = sinkListIterator.value();
if (!(sinkListIterator == this->sinkList.end())) {
unregisterSuccess = sink.first->UnregisterControlChangeNotify(sink.second); // unregister ControlChangeNotify before doing any changes to a sink
} HRESULT unregisterSuccess = sink.first->UnregisterControlChangeNotify(sink.second);
if (np.has(QStringLiteral("volume"))) { if (np.has(QStringLiteral("volume"))) {
float currentVolume; float currentVolume;