From e38cdb111b461c363b1454e19c8c1c73e23a9a24 Mon Sep 17 00:00:00 2001
From: Nicolas Fella <nicolas.fella@gmx.de>
Date: Wed, 29 Jul 2020 00:07:40 +0200
Subject: [PATCH] Add missing references to loop variable

---
 plugins/sms/smsplugin.cpp                    | 2 +-
 smsapp/conversationssortfilterproxymodel.cpp | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/plugins/sms/smsplugin.cpp b/plugins/sms/smsplugin.cpp
index 27074584f..335447544 100644
--- a/plugins/sms/smsplugin.cpp
+++ b/plugins/sms/smsplugin.cpp
@@ -62,7 +62,7 @@ void SmsPlugin::sendSms(const QDBusVariant& addresses, const QString& messageBod
     QList<ConversationAddress> addressList = ConversationAddress::listfromDBus(addresses);
 
     QVariantList addressMapList;
-    for (const ConversationAddress address : addressList) {
+    for (const ConversationAddress& address : addressList) {
         QVariantMap addressMap({{QStringLiteral("address"), address.address()}});
         addressMapList.append(addressMap);
         qDebug() <<address.address();
diff --git a/smsapp/conversationssortfilterproxymodel.cpp b/smsapp/conversationssortfilterproxymodel.cpp
index f90a26b32..6ca2432c0 100644
--- a/smsapp/conversationssortfilterproxymodel.cpp
+++ b/smsapp/conversationssortfilterproxymodel.cpp
@@ -67,8 +67,8 @@ bool ConversationsSortFilterProxyModel::filterAcceptsRow(int sourceRow, const QM
         }
 
         // This block of code compares each address in the multi target conversation to find a match
-        QList<ConversationAddress> addressList = sourceModel()->data(index, ConversationListModel::AddressesRole).value<QList<ConversationAddress>>();
-        for (const ConversationAddress address : addressList) {
+        const QList<ConversationAddress> addressList = sourceModel()->data(index, ConversationListModel::AddressesRole).value<QList<ConversationAddress>>();
+        for (const ConversationAddress& address : addressList) {
             QString canonicalAddress = SmsHelper::canonicalizePhoneNumber(address.address());
             if (canonicalAddress.contains(filterRegExp())) {
                 return true;