tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fixed crash

Browse source 
QIODevice was deleted when DownloadJob was autodeleted, causing dangling
pointers.
This commit is contained in:
Albert Vaca 2013-09-18 18:35:08 +02:00
parent f8825e013e
commit ddbbafab63
1 changed files with 3 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
kded/backends/lan/downloadjob.cpp
View file

@ -23,12 +23,13 @@
DownloadJob::DownloadJob(QHostAddress address, QVariantMap transferInfo): KJob() DownloadJob::DownloadJob(QHostAddress address, QVariantMap transferInfo): KJob()
{ {
mPort = transferInfo["port"].toInt(); mPort = transferInfo["port"].toInt();
mSocket = new QTcpSocket(this); mSocket = new QTcpSocket();
mAddress = address; mAddress = address;
} }
void DownloadJob::start() void DownloadJob::start()
{ {
qDebug() << "start";
mSocket->connectToHost(mAddress, mPort, QIODevice::ReadOnly); mSocket->connectToHost(mAddress, mPort, QIODevice::ReadOnly);
connect(mSocket, SIGNAL(disconnected()), this, SLOT(disconnected())); connect(mSocket, SIGNAL(disconnected()), this, SLOT(disconnected()));
} }
@ -40,5 +41,6 @@ void DownloadJob::disconnected()
QIODevice* DownloadJob::getPayload() QIODevice* DownloadJob::getPayload()
{ {
qDebug() << "getPayload";
return mSocket; return mSocket;
} }