diff --git a/declarativeplugin/responsewaiter.cpp b/declarativeplugin/responsewaiter.cpp index 683a05350..a03be4e4f 100644 --- a/declarativeplugin/responsewaiter.cpp +++ b/declarativeplugin/responsewaiter.cpp @@ -43,7 +43,7 @@ DBusResponseWaiter::DBusResponseWaiter() ; } -QVariant DBusResponseWaiter::waitForReply(QVariant variant) const +QVariant DBusResponseWaiter::waitForReply(const QVariant &variant) const { if (QDBusPendingCall* call = extractPendingCall(variant)) { @@ -74,8 +74,7 @@ DBusAsyncResponse::DBusAsyncResponse(QObject* parent) connect(&m_timeout, &QTimer::timeout, this, &DBusAsyncResponse::onTimeout); } - -void DBusAsyncResponse::setPendingCall(QVariant variant) +void DBusAsyncResponse::setPendingCall(const QVariant &variant) { if (QDBusPendingCall* call = DBusResponseWaiter::instance()->extractPendingCall(variant)) { @@ -124,7 +123,7 @@ void DBusAsyncResponse::onTimeout() Q_EMIT error(QStringLiteral("timeout when waiting dbus response!")); } -QDBusPendingCall* DBusResponseWaiter::extractPendingCall(QVariant& variant) const +QDBusPendingCall* DBusResponseWaiter::extractPendingCall(const QVariant& variant) const { for (int type : qAsConst(m_registered)) { diff --git a/declarativeplugin/responsewaiter.h b/declarativeplugin/responsewaiter.h index b25a74685..d7cc37758 100644 --- a/declarativeplugin/responsewaiter.h +++ b/declarativeplugin/responsewaiter.h @@ -23,9 +23,9 @@ public: static DBusResponseWaiter* instance(); ///extract QDbusPendingCall from \p variant and blocks until completed - Q_INVOKABLE QVariant waitForReply(QVariant variant) const; + Q_INVOKABLE QVariant waitForReply(const QVariant &variant) const; - QDBusPendingCall* extractPendingCall(QVariant& variant) const; + QDBusPendingCall* extractPendingCall(const QVariant& variant) const; private: DBusResponseWaiter(); @@ -44,7 +44,7 @@ public: explicit DBusAsyncResponse(QObject* parent = nullptr); ~DBusAsyncResponse() override = default; - Q_INVOKABLE void setPendingCall(QVariant e); + Q_INVOKABLE void setPendingCall(const QVariant &e); void setAutodelete(bool b) {m_autodelete = b;}; bool autodelete() const {return m_autodelete;}