tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add sanity check to dbus-exposed requestConversation()

Browse source
This commit is contained in:
Nicolas Fella 2019-05-01 12:47:33 +00:00
parent 3eb2f67d38
commit c18c7b27f1
1 changed files with 10 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

10
plugins/sms/conversationsdbusinterface.cpp
View file

@ -91,6 +91,16 @@ QVariantList ConversationsDbusInterface::activeConversations()
void ConversationsDbusInterface::requestConversation(const qint64& conversationID, int start, int end) void ConversationsDbusInterface::requestConversation(const qint64& conversationID, int start, int end)
{ {
if (start < 0 || end < 0) {
qCWarning(KDECONNECT_CONVERSATIONS) << "requestConversation" << "Start and end must be >= 0";
return;
}
if (end - start < 0) {
qCWarning(KDECONNECT_CONVERSATIONS) << "requestConversation" <<"Start must be before end";
return;
}
RequestConversationWorker* worker = new RequestConversationWorker(conversationID, start, end, this); RequestConversationWorker* worker = new RequestConversationWorker(conversationID, start, end, this);
connect(worker, &RequestConversationWorker::conversationMessageRead, connect(worker, &RequestConversationWorker::conversationMessageRead,
this, &ConversationsDbusInterface::conversationUpdated, this, &ConversationsDbusInterface::conversationUpdated,