From bfdb1c7ff52f730ad3934656a6da674dd260f63f Mon Sep 17 00:00:00 2001 From: Fabian Arndt Date: Fri, 31 May 2024 20:31:21 +0000 Subject: [PATCH] Virtual Monitor: always provide dbus path The plugin should always be loaded, as: - we can provide a virtual display over VNC, even if the device isn't capable to use virtual displays itself (`krfb-virtualmonitor`) - we would do the capabilities check regardless, if !670 gets merged - hiding the DBus path doesn't trigger the `PluginChecker.qml` to think the plugin is unavailable, it just doesn't work - -> is this a bug or intended behaviour? --- plugins/virtualmonitor/virtualmonitorplugin.cpp | 4 ---- 1 file changed, 4 deletions(-) diff --git a/plugins/virtualmonitor/virtualmonitorplugin.cpp b/plugins/virtualmonitor/virtualmonitorplugin.cpp index a4c616bd4..db65cfea4 100644 --- a/plugins/virtualmonitor/virtualmonitorplugin.cpp +++ b/plugins/virtualmonitor/virtualmonitorplugin.cpp @@ -119,10 +119,6 @@ void VirtualMonitorPlugin::receivePacket(const NetworkPacket &received) QString VirtualMonitorPlugin::dbusPath() const { - // Don't offer the feature if krfb-virtualmonitor is not around - if (!m_capabilitiesLocal.virtualMonitor) - return {}; - return QLatin1String("/modules/kdeconnect/devices/%1/virtualmonitor").arg(device()->id()); }