tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Correct reference to NetworkPacket in isValidIdentityPacket calls

Browse source 
## Summary

Fix Bluetooth branch build errors for changes in !678

## Test Plan

### Before:
Build errors in bluetoothlinkprovider.cpp due to undefined variable and due to incorrect argument type.

```
/home/simon/src/kdeconnect-kde/core/backends/bluetooth/bluetoothlinkprovider.cpp:301:56: error: cann
ot convert ‘NetworkPacket’ to ‘NetworkPacket*’
  301 |     if (!success || !DeviceInfo::isValidIdentityPacket(receivedPacket)) {
      |                                                        ^~~~~~~~~~~~~~
      |                                                        |
      |                                                        NetworkPacket
<snip>
```

### After:
Clean build.
This commit is contained in:
Simon Redman 2024-06-10 20:59:03 +00:00
parent 11ef11c0c3
commit a6fd9f9e9e
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
core/backends/bluetooth/bluetoothlinkprovider.cpp
View file

@ -194,7 +194,7 @@ void BluetoothLinkProvider::clientIdentityReceived(const QBluetoothAddress &peer
NetworkPacket receivedPacket; NetworkPacket receivedPacket;
bool success = NetworkPacket::unserialize(identityArray, &receivedPacket); bool success = NetworkPacket::unserialize(identityArray, &receivedPacket);
if (!success || !DeviceInfo::isValidIdentityPacket(np)) { if (!success || !DeviceInfo::isValidIdentityPacket(&receivedPacket)) {
qCWarning(KDECONNECT_CORE) << "BluetoothLinkProvider: Invalid identity packet received"; qCWarning(KDECONNECT_CORE) << "BluetoothLinkProvider: Invalid identity packet received";
mSockets.remove(peer); mSockets.remove(peer);
socket->close(); socket->close();
@ -298,7 +298,7 @@ void BluetoothLinkProvider::serverDataReceived(const QBluetoothAddress &peer, QS
NetworkPacket receivedPacket; NetworkPacket receivedPacket;
bool success = NetworkPacket::unserialize(identityArray, &receivedPacket); bool success = NetworkPacket::unserialize(identityArray, &receivedPacket);
if (!success || !DeviceInfo::isValidIdentityPacket(receivedPacket)) { if (!success || !DeviceInfo::isValidIdentityPacket(&receivedPacket)) {
qCWarning(KDECONNECT_CORE) << "BluetoothLinkProvider: Invalid identity packet received"; qCWarning(KDECONNECT_CORE) << "BluetoothLinkProvider: Invalid identity packet received";
mSockets.remove(peer); mSockets.remove(peer);
socket->close(); socket->close();