tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Test if file was received completely if not delete the partial file

Browse source 
Summary: If the number of bytes received != m_size report failure and delete the partial file

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: kdeconnect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D16778
This commit is contained in:
Erik Duisters 2018-11-09 13:58:28 +01:00
parent 9fc55c72f0
commit 7cb4de20c1
1 changed files with 16 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
core/filetransferjob.cpp
View file

@ -102,6 +102,8 @@ void FileTransferJob::startTransfer()
if (elapsed > 0) {
emitSpeed((1000 * bytesSent) / elapsed);
}
m_written = bytesSent;
});
connect(m_reply, static_cast<void (QNetworkReply::*)(QNetworkReply::NetworkError)>(&QNetworkReply::error),
this, &FileTransferJob::transferFailed);
@ -121,9 +123,21 @@ void FileTransferJob::transferFailed(QNetworkReply::NetworkError error)
void FileTransferJob::transferFinished()
{
//TODO: MD5-check the file
if (m_size == m_written) {
qCDebug(KDECONNECT_CORE) << "Finished transfer" << m_destination;
emitResult();
} else {
qCDebug(KDECONNECT_CORE) << "Received incomplete file, deleting";
if (m_destination.isLocalFile() && QFile::exists(m_destination.toLocalFile())) {
QFile::remove(m_destination.toLocalFile());
}
setError(3);
setErrorText(i18n("Received incomplete file from: %1", m_from));
emitResult();
}
}
bool FileTransferJob::doKill()