tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Fix infinite loop when already paired devices ask to pair

Browse source
This commit is contained in:
Albert Vaca Cintora 2023-06-16 19:49:39 +02:00
parent d690119e4d
commit 7ca8b7bf95
1 changed files with 8 additions and 3 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

11
core/backends/pairinghandler.cpp
View file

@ -33,10 +33,15 @@ void PairingHandler::packetReceived(const NetworkPacket &np)
qCDebug(KDECONNECT_CORE) << "Ignoring second pairing request before the first one timed out";
break;
case PairState::Paired:
qCDebug(KDECONNECT_CORE) << "Auto-accepting pairing request from a device we already trusted";
acceptPairing();
break;
case PairState::NotPaired:
if (m_pairState == PairState::Paired) {
qWarning() << "Received pairing request from a device we already trusted.";
// It would be nice to auto-accept the pairing request here, but since the pairing accept and pairing request
// messages are identical, this could create an infinite loop if both devices are "accepting" each other pairs.
// Instead, unpair and handle as if "NotPaired".
m_pairState = PairState::NotPaired;
Q_EMIT unpaired();
}
m_pairState = PairState::RequestedByPeer;
m_pairingTimeout.start();
Q_EMIT incomingPairRequest();