tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Show no notification icon if there is no

Browse source 
Summary: I think it looks nicer than the kind of angry default icon and is the expected behaviour

Reviewers: #kde_connect, albertvaka

Reviewed By: #kde_connect, albertvaka

Subscribers: albertvaka, apol, #kde_connect

Tags: #kde_connect

Differential Revision: https://phabricator.kde.org/D6089
This commit is contained in:
Nicolas Fella 2017-07-11 23:26:14 +02:00
parent 29888cb78b
commit 732462135f
1 changed files with 4 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins/notifications/notification.cpp
View file

@ -102,7 +102,8 @@ KNotification* Notification::createKNotification(bool update, const NetworkPacka
}
if (!mHasIcon) {
mNotification->setIconName(QStringLiteral("preferences-desktop-notification"));
//HACK The only way to display no icon at all is trying to load a non-existant icon
mNotification->setIconName(QString("not_a_real_icon"));
show();
} else {
QString filename = mPayloadHash;
@ -117,11 +118,11 @@ KNotification* Notification::createKNotification(bool update, const NetworkPacka
connect(job, &FileTransferJob::result, this, &Notification::applyIconAndShow);
}
}
if(!mRequestReplyId.isEmpty()) {
mNotification->setActions( QStringList(i18n("Reply")) );
connect(mNotification, &KNotification::action1Activated, this, &Notification::reply);
}
}
connect(mNotification, &KNotification::closed, this, &Notification::closed);
@ -151,4 +152,3 @@ void Notification::parseNetworkPackage(const NetworkPackage &np)
mPayloadHash = np.get<QString>(QStringLiteral("payloadHash"));
mRequestReplyId = np.get<QString>(QStringLiteral("requestReplyId"), QString());
}