tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not mark plugin classes as exported

Browse source 
This is not needed, because only a symbol to create the KPluginFactory
instance must be exported. The KPluginFactory macros or rather the underlying
Q_PLUGIN_METADATA macro already take care of that.

In other plugin code of KDE, we also do not export classes.
The size of the generated plugin files is nearly identical, but removing
the macros avoids confusion for developers.
This commit is contained in:
Alexander Lohnau 2023-07-22 11:37:35 +02:00 committed by Albert Vaca Cintora
parent 75a8db1ec5
commit 7091f333f9
20 changed files with 20 additions and 20 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/bigscreen/bigscreenplugin.h
View file

@ -11,7 +11,7 @@
#define PACKET_TYPE_BIGSCREEN_STT QStringLiteral("kdeconnect.bigscreen.stt")
class Q_DECL_EXPORT BigscreenPlugin : public KdeConnectPlugin
class BigscreenPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.bigscreen")

2
plugins/contacts/contactsplugin.h
View file

@ -75,7 +75,7 @@ Q_DECLARE_METATYPE(uID)
typedef QStringList uIDList_t;
Q_DECLARE_METATYPE(uIDList_t)
class Q_DECL_EXPORT ContactsPlugin : public KdeConnectPlugin
class ContactsPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.contacts")

2
plugins/lockdevice/lockdeviceplugin-win.h
View file

@ -13,7 +13,7 @@
#define PACKET_TYPE_LOCK QStringLiteral("kdeconnect.lock")
#define PACKET_TYPE_LOCK_REQUEST QStringLiteral("kdeconnect.lock.request")
class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin
class LockDevicePlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.lockdevice")

2
plugins/lockdevice/lockdeviceplugin.h
View file

@ -16,7 +16,7 @@
#define PACKET_TYPE_LOCK QStringLiteral("kdeconnect.lock")
#define PACKET_TYPE_LOCK_REQUEST QStringLiteral("kdeconnect.lock.request")
class Q_DECL_EXPORT LockDevicePlugin : public KdeConnectPlugin
class LockDevicePlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.lockdevice")

2
plugins/mpriscontrol/mpriscontrolplugin-win.h
View file

@ -25,7 +25,7 @@ using namespace Windows::ApplicationModel;
#define PACKET_TYPE_MPRIS QStringLiteral("kdeconnect.mpris")
class Q_DECL_EXPORT MprisControlPlugin : public KdeConnectPlugin
class MprisControlPlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/mprisremote/mprisremoteplugin.h
View file

@ -15,7 +15,7 @@
#define PACKET_TYPE_MPRIS_REQUEST QStringLiteral("kdeconnect.mpris.request")
#define PACKET_TYPE_MPRIS QStringLiteral("kdeconnect.mpris")
class Q_DECL_EXPORT MprisRemotePlugin : public KdeConnectPlugin
class MprisRemotePlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.mprisremote")

2
plugins/photo/photoplugin.h
View file

@ -13,7 +13,7 @@ class QObject;
#define PACKET_TYPE_PHOTO_REQUEST QStringLiteral("kdeconnect.photo.request")
#define PACKET_TYPE_PHOTO QStringLiteral("kdeconnect.photo")
class Q_DECL_EXPORT PhotoPlugin : public KdeConnectPlugin
class PhotoPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.photo")

2
plugins/ping/pingplugin.h
View file

@ -12,7 +12,7 @@
#define PACKET_TYPE_PING QStringLiteral("kdeconnect.ping")
class Q_DECL_EXPORT PingPlugin : public KdeConnectPlugin
class PingPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.ping")

2
plugins/presenter/presenterplugin.h
View file

@ -16,7 +16,7 @@
class PresenterView;
class Q_DECL_EXPORT PresenterPlugin : public KdeConnectPlugin
class PresenterPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.presenter")

2
plugins/remotecommands/remotecommandsplugin.h
View file

@ -11,7 +11,7 @@ class QObject;
#include <QString>
#include <core/kdeconnectplugin.h>
class Q_DECL_EXPORT RemoteCommandsPlugin : public KdeConnectPlugin
class RemoteCommandsPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotecommands")

2
plugins/remotecontrol/remotecontrolplugin.h
View file

@ -12,7 +12,7 @@
#define PACKET_TYPE_MOUSEPAD_REQUEST QStringLiteral("kdeconnect.mousepad.request")
class Q_DECL_EXPORT RemoteControlPlugin : public KdeConnectPlugin
class RemoteControlPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotecontrol")

2
plugins/remotesystemvolume/remotesystemvolumeplugin.h
View file

@ -13,7 +13,7 @@
#define PACKET_TYPE_SYSTEMVOLUME QStringLiteral("kdeconnect.systemvolume")
#define PACKET_TYPE_SYSTEMVOLUME_REQUEST QStringLiteral("kdeconnect.systemvolume.request")
class Q_DECL_EXPORT RemoteSystemVolumePlugin : public KdeConnectPlugin
class RemoteSystemVolumePlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotesystemvolume")

2
plugins/runcommand/runcommandplugin.h
View file

@ -15,7 +15,7 @@
#include <QString>
#include <core/kdeconnectplugin.h>
class Q_DECL_EXPORT RunCommandPlugin : public KdeConnectPlugin
class RunCommandPlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/screensaver-inhibit/screensaverinhibitplugin-macos.h
View file

@ -11,7 +11,7 @@
#include <core/kdeconnectplugin.h>
class Q_DECL_EXPORT ScreensaverInhibitPlugin : public KdeConnectPlugin
class ScreensaverInhibitPlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/screensaver-inhibit/screensaverinhibitplugin-win.h
View file

@ -10,7 +10,7 @@
#include <core/kdeconnectplugin.h>
class Q_DECL_EXPORT ScreensaverInhibitPlugin : public KdeConnectPlugin
class ScreensaverInhibitPlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/screensaver-inhibit/screensaverinhibitplugin.h
View file

@ -10,7 +10,7 @@
#include <core/kdeconnectplugin.h>
class Q_DECL_EXPORT ScreensaverInhibitPlugin : public KdeConnectPlugin
class ScreensaverInhibitPlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/sms/smsplugin.h
View file

@ -137,7 +137,7 @@ Q_DECLARE_LOGGING_CATEGORY(KDECONNECT_PLUGIN_SMS)
class QTextCodec;
class Q_DECL_EXPORT SmsPlugin : public KdeConnectPlugin
class SmsPlugin : public KdeConnectPlugin
{
Q_OBJECT
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.sms")

2
plugins/systemvolume/systemvolumeplugin-macos.h
View file

@ -18,7 +18,7 @@
class MacOSCoreAudioDevice;
class Q_DECL_EXPORT SystemvolumePlugin : public KdeConnectPlugin
class SystemvolumePlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/systemvolume/systemvolumeplugin-pulse.h
View file

@ -16,7 +16,7 @@
#define PACKET_TYPE_SYSTEMVOLUME QStringLiteral("kdeconnect.systemvolume")
#define PACKET_TYPE_SYSTEMVOLUME_REQUEST QStringLiteral("kdeconnect.systemvolume.request")
class Q_DECL_EXPORT SystemvolumePlugin : public KdeConnectPlugin
class SystemvolumePlugin : public KdeConnectPlugin
{
Q_OBJECT

2
plugins/systemvolume/systemvolumeplugin-win.h
View file

@ -22,7 +22,7 @@
#define PACKET_TYPE_SYSTEMVOLUME QStringLiteral("kdeconnect.systemvolume")
#define PACKET_TYPE_SYSTEMVOLUME_REQUEST QStringLiteral("kdeconnect.systemvolume.request")
class Q_DECL_EXPORT SystemvolumePlugin : public KdeConnectPlugin
class SystemvolumePlugin : public KdeConnectPlugin
{
Q_OBJECT