tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

plugins: Prefer using statements with baseclass over empty constructor

Browse source 
Those plugins re really simple and don't need any initialization logic.
With the using statement, we do not need to add a constructor and pass the parent/args to the baseclass
This commit is contained in:
Alexander Lohnau 2023-07-28 10:36:48 +02:00
parent 867c4ab6fc
commit 6530274f75
24 changed files with 12 additions and 80 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
plugins/bigscreen/bigscreenplugin.cpp
View file

@ -20,11 +20,6 @@ K_PLUGIN_CLASS_WITH_JSON(BigscreenPlugin, "kdeconnect_bigscreen.json")
Q_LOGGING_CATEGORY(KDECONNECT_PLUGIN_BIGSCREEN, "kdeconnect.plugin.bigscreen")
BigscreenPlugin::BigscreenPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool BigscreenPlugin::receivePacket(const NetworkPacket &np)
{
QString message = np.get<QString>(QStringLiteral("content"));

3
plugins/bigscreen/bigscreenplugin.h
View file

@ -17,8 +17,7 @@ class BigscreenPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.bigscreen")
public:
explicit BigscreenPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket &np) override;
QString dbusPath() const override;

5
plugins/connectivity-report/connectivity_reportplugin.cpp
View file

@ -15,11 +15,6 @@
K_PLUGIN_CLASS_WITH_JSON(ConnectivityReportPlugin, "kdeconnect_connectivity_report.json")
ConnectivityReportPlugin::ConnectivityReportPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
QString ConnectivityReportPlugin::cellularNetworkType() const
{
return m_cellularNetworkType;

2
plugins/connectivity-report/connectivity_reportplugin.h
View file

@ -39,7 +39,7 @@ class ConnectivityReportPlugin : public KdeConnectPlugin
Q_PROPERTY(int cellularNetworkStrength READ cellularNetworkStrength NOTIFY refreshed)
public:
explicit ConnectivityReportPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket &np) override;
QString dbusPath() const override;

5
plugins/findmyphone/findmyphoneplugin.cpp
View file

@ -14,11 +14,6 @@
K_PLUGIN_CLASS_WITH_JSON(FindMyPhonePlugin, "kdeconnect_findmyphone.json")
FindMyPhonePlugin::FindMyPhonePlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool FindMyPhonePlugin::receivePacket(const NetworkPacket & /*np*/)
{
return false;

2
plugins/findmyphone/findmyphoneplugin.h
View file

@ -18,7 +18,7 @@ class FindMyPhonePlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.findmyphone")
public:
explicit FindMyPhonePlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
Q_SCRIPTABLE void ring();

5
plugins/findthisdevice/findthisdeviceplugin.cpp
View file

@ -26,11 +26,6 @@
K_PLUGIN_CLASS_WITH_JSON(FindThisDevicePlugin, "kdeconnect_findthisdevice.json")
FindThisDevicePlugin::FindThisDevicePlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool FindThisDevicePlugin::receivePacket(const NetworkPacket & /*np*/)
{
const QString soundFile = config()->getString(QStringLiteral("ringtone"), defaultSound());

2
plugins/findthisdevice/findthisdeviceplugin.h
View file

@ -27,7 +27,7 @@ class FindThisDevicePlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.findthisdevice")
public:
explicit FindThisDevicePlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
QString dbusPath() const override;
bool receivePacket(const NetworkPacket &np) override;

5
plugins/mprisremote/mprisremoteplugin.cpp
View file

@ -16,11 +16,6 @@
K_PLUGIN_CLASS_WITH_JSON(MprisRemotePlugin, "kdeconnect_mprisremote.json")
MprisRemotePlugin::MprisRemotePlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool MprisRemotePlugin::receivePacket(const NetworkPacket &np)
{
if (np.type() != PACKET_TYPE_MPRIS)

2
plugins/mprisremote/mprisremoteplugin.h
View file

@ -31,7 +31,7 @@ class MprisRemotePlugin : public KdeConnectPlugin
Q_PROPERTY(bool canSeek READ canSeek NOTIFY propertiesChanged)
public:
explicit MprisRemotePlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
long position() const;
int volume() const;

5
plugins/notifications/notificationsplugin.cpp
View file

@ -22,11 +22,6 @@
K_PLUGIN_CLASS_WITH_JSON(NotificationsPlugin, "kdeconnect_notifications.json")
NotificationsPlugin::NotificationsPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
void NotificationsPlugin::connected()
{
NetworkPacket np(PACKET_TYPE_NOTIFICATION_REQUEST, {{QStringLiteral("request"), true}});

2
plugins/notifications/notificationsplugin.h
View file

@ -20,7 +20,7 @@ class NotificationsPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.notifications")
public:
explicit NotificationsPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket &np) override;
void connected() override;

5
plugins/photo/photoplugin.cpp
View file

@ -15,11 +15,6 @@
K_PLUGIN_CLASS_WITH_JSON(PhotoPlugin, "kdeconnect_photo.json")
PhotoPlugin::PhotoPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool PhotoPlugin::receivePacket(const NetworkPacket &np)
{
if (np.get<bool>(QStringLiteral("cancel"))) {

2
plugins/photo/photoplugin.h
View file

@ -19,7 +19,7 @@ class PhotoPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.photo")
public:
explicit PhotoPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
Q_SCRIPTABLE void requestPhoto(const QString &url);

11
plugins/ping/pingplugin.cpp
View file

@ -19,17 +19,6 @@
K_PLUGIN_CLASS_WITH_JSON(PingPlugin, "kdeconnect_ping.json")
PingPlugin::PingPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
// qCDebug(KDECONNECT_PLUGIN_PING) << "Ping plugin constructor for device" << device()->name();
}
PingPlugin::~PingPlugin()
{
// qCDebug(KDECONNECT_PLUGIN_PING) << "Ping plugin destructor for device" << device()->name();
}
bool PingPlugin::receivePacket(const NetworkPacket &np)
{
Daemon::instance()->sendSimpleNotification(QStringLiteral("pingReceived"),

3
plugins/ping/pingplugin.h
View file

@ -18,8 +18,7 @@ class PingPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.ping")
public:
explicit PingPlugin(QObject *parent, const QVariantList &args);
~PingPlugin() override;
using KdeConnectPlugin::KdeConnectPlugin;
Q_SCRIPTABLE void sendPing();
Q_SCRIPTABLE void sendPing(const QString &customMessage);

5
plugins/remotecontrol/remotecontrolplugin.cpp
View file

@ -18,11 +18,6 @@
K_PLUGIN_CLASS_WITH_JSON(RemoteControlPlugin, "kdeconnect_remotecontrol.json")
RemoteControlPlugin::RemoteControlPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
void RemoteControlPlugin::moveCursor(const QPoint &p)
{
NetworkPacket np(PACKET_TYPE_MOUSEPAD_REQUEST, {{QStringLiteral("dx"), p.x()}, {QStringLiteral("dy"), p.y()}});

2
plugins/remotecontrol/remotecontrolplugin.h
View file

@ -18,7 +18,7 @@ class RemoteControlPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.remotecontrol")
public:
explicit RemoteControlPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket & /*np*/) override
{

5
plugins/remotesystemvolume/remotesystemvolumeplugin.cpp
View file

@ -21,11 +21,6 @@
K_PLUGIN_CLASS_WITH_JSON(RemoteSystemVolumePlugin, "kdeconnect_remotesystemvolume.json")
RemoteSystemVolumePlugin::RemoteSystemVolumePlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
bool RemoteSystemVolumePlugin::receivePacket(const NetworkPacket &np)
{
if (np.has(QStringLiteral("sinkList"))) {

2
plugins/remotesystemvolume/remotesystemvolumeplugin.h
View file

@ -21,7 +21,7 @@ class RemoteSystemVolumePlugin : public KdeConnectPlugin
Q_PROPERTY(QString deviceId READ deviceId CONSTANT)
public:
explicit RemoteSystemVolumePlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket &np) override;
void connected() override;

5
plugins/telephony/telephonyplugin.cpp
View file

@ -17,11 +17,6 @@
K_PLUGIN_CLASS_WITH_JSON(TelephonyPlugin, "kdeconnect_telephony.json")
TelephonyPlugin::TelephonyPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
void TelephonyPlugin::createNotification(const NetworkPacket &np)
{
const QString event = np.get<QString>(QStringLiteral("event"));

2
plugins/telephony/telephonyplugin.h
View file

@ -35,7 +35,7 @@ class TelephonyPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.telephony")
public:
explicit TelephonyPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
bool receivePacket(const NetworkPacket &np) override;
QString dbusPath() const override;

5
plugins/virtualmonitor/virtualmonitorplugin.cpp
View file

@ -19,11 +19,6 @@
K_PLUGIN_CLASS_WITH_JSON(VirtualMonitorPlugin, "kdeconnect_virtualmonitor.json")
#define QS QLatin1String
VirtualMonitorPlugin::VirtualMonitorPlugin(QObject *parent, const QVariantList &args)
: KdeConnectPlugin(parent, args)
{
}
VirtualMonitorPlugin::~VirtualMonitorPlugin()
{
stop();

2
plugins/virtualmonitor/virtualmonitorplugin.h
View file

@ -21,7 +21,7 @@ class VirtualMonitorPlugin : public KdeConnectPlugin
Q_CLASSINFO("D-Bus Interface", "org.kde.kdeconnect.device.virtualmonitor")
public:
explicit VirtualMonitorPlugin(QObject *parent, const QVariantList &args);
using KdeConnectPlugin::KdeConnectPlugin;
~VirtualMonitorPlugin() override;
Q_SCRIPTABLE bool requestVirtualMonitor();