tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Do not prevent our own change notifications

Browse source 
In Linux we send them, and we actually rely on those on the Android app
for mute/unmute to update (although not for volume).
This commit is contained in:
Albert Vaca Cintora 2023-05-25 16:19:39 +02:00
parent ab57796051
commit 39050f9844
1 changed files with 0 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
plugins/systemvolume/systemvolumeplugin-win.cpp
View file

@ -413,9 +413,6 @@ bool SystemvolumePlugin::receivePacket(const NetworkPacket &np)
if (sinkListIterator != this->sinkList.end()) { if (sinkListIterator != this->sinkList.end()) {
auto &sink = sinkListIterator.value(); auto &sink = sinkListIterator.value();
// unregister ControlChangeNotify before doing any changes to a sink
HRESULT unregisterSuccess = sink.first->UnregisterControlChangeNotify(sink.second);
if (np.has(QStringLiteral("volume"))) { if (np.has(QStringLiteral("volume"))) {
float requestedVolume = (float)np.get<int>(QStringLiteral("volume"), 100) / 100; float requestedVolume = (float)np.get<int>(QStringLiteral("volume"), 100) / 100;
sinkList[name].first->SetMasterVolumeLevelScalar(requestedVolume, NULL); sinkList[name].first->SetMasterVolumeLevelScalar(requestedVolume, NULL);
@ -442,10 +439,6 @@ bool SystemvolumePlugin::receivePacket(const NetworkPacket &np)
} }
} }
// re-register ControlChangeNotify in case we unregistered it
if (unregisterSuccess == S_OK) {
sink.first->RegisterControlChangeNotify(sink.second);
}
} }
} }
return true; return true;