tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Connectivity Report] Only emit signal when it has actually changed

Browse source 
Avoids pointless DBus traffic
This commit is contained in:
Kai Uwe Broulik 2021-11-30 23:33:30 +01:00
parent 034e5fb03c
commit 2a3ab4104e
1 changed files with 7 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

8
plugins/connectivity-report/connectivity_reportplugin.cpp
View file

@ -43,10 +43,16 @@ bool ConnectivityReportPlugin::receivePacket(const NetworkPacket& np)
auto subscriptions = np.get<QVariantMap>(QStringLiteral("signalStrengths"), QVariantMap()); auto subscriptions = np.get<QVariantMap>(QStringLiteral("signalStrengths"), QVariantMap());
auto networkInfo = subscriptions.first().toMap(); auto networkInfo = subscriptions.first().toMap();
const auto oldCellularNetworkType = m_cellularNetworkType;
const auto oldNetworkStrength = m_cellularNetworkStrength;
m_cellularNetworkType = networkInfo.value(QStringLiteral("networkType")).toString(); m_cellularNetworkType = networkInfo.value(QStringLiteral("networkType")).toString();
m_cellularNetworkStrength = networkInfo.value(QStringLiteral("signalStrength")).toInt(); m_cellularNetworkStrength = networkInfo.value(QStringLiteral("signalStrength")).toInt();
Q_EMIT refreshed(m_cellularNetworkType, m_cellularNetworkStrength); if (oldCellularNetworkType != m_cellularNetworkType ||
oldNetworkStrength != m_cellularNetworkStrength) {
Q_EMIT refreshed(m_cellularNetworkType, m_cellularNetworkStrength);
}
} }
return true; return true;