tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix: don't send clipboard network packets on empty text

Browse source 
If you lock the screen in EndeavourOS, a signal KSystemClipboard:changed is emitted with empty text and clipboard mode QClipboard::Clipboard. Upon unlock the clipboard will be re-synced.

A clipboard network packet will be sent for KSystemClipboard::changed signals if:
1. the received mode is QClipboard::Clipboard
2. the new content and its type are different from the current ones.

The problem here is that, before locking the screen, current content is not empty. As of condition #2, a network packet with the empty text will be sent, which clears the current clipboard selection in GBoard but the contents stay the same. Upon re-sync in unlock, a packet will be sent again due to #2.

This commit aims to fix this by ignoring empty text updates since from the end-user it unnecessarily clears the current clipboard selection and results in many "Copied to clipboard" toasts.
This commit is contained in:
Arjan Marku 2024-03-24 20:07:30 +01:00 committed by Albert Vaca Cintora
parent 2295f6968b
commit 16ccee7ac9
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
plugins/clipboard/clipboardlistener.cpp
View file

@ -66,7 +66,7 @@ void ClipboardListener::updateClipboard(QClipboard::Mode mode)
} }
const QString content = clipboard->text(QClipboard::Clipboard); const QString content = clipboard->text(QClipboard::Clipboard);
if (content == m_currentContent && contentType == m_currentContentType) { if ((content.isEmpty() || content == m_currentContent) && contentType == m_currentContentType) {
return; return;
} }
refreshContent(content, contentType); refreshContent(content, contentType);