From 0741a7db8839b92024d5919edce8c5212c51dac1 Mon Sep 17 00:00:00 2001
From: Albert Vaca Cintora <albertvaka@gmail.com>
Date: Fri, 7 Jul 2023 00:49:28 +0200
Subject: [PATCH] Add commented code to parse the fields we don't store

---
 core/backends/lan/mdns_wrapper.cpp | 16 ++++++++++++----
 core/backends/lan/mdns_wrapper.h   |  2 +-
 2 files changed, 13 insertions(+), 5 deletions(-)

diff --git a/core/backends/lan/mdns_wrapper.cpp b/core/backends/lan/mdns_wrapper.cpp
index e92f21065..96efb8a81 100644
--- a/core/backends/lan/mdns_wrapper.cpp
+++ b/core/backends/lan/mdns_wrapper.cpp
@@ -70,15 +70,21 @@ static int query_callback(int sock, const struct sockaddr* from, size_t addrlen,
 
     switch (record_type) {
     case MDNS_RECORDTYPE_PTR: {
-        mdns_string_pair_t namePos = mdns_get_next_substring(data, size, record_offset);
-        discoveredService->serviceName = QString::fromLatin1((char *)data + namePos.offset, namePos.length);
+        // Keep just the service name instead of the full "<service-name>.<_service-type>._tcp.local." string
+        mdns_string_pair_t serviceNamePos = mdns_get_next_substring(data, size, record_offset);
+        discoveredService->serviceName = QString::fromLatin1((char *)data + serviceNamePos.offset, serviceNamePos.length);
+        //static char serviceNameBuffer[256];
+        //mdns_string_t serviceName = mdns_record_parse_ptr(data, size, record_offset, record_length, serviceNameBuffer, sizeof(serviceNameBuffer));
+        //discoveredService->serviceName = QString::fromLatin1(serviceName.str, serviceName.length);
         if (discoveredService->address == QHostAddress::Null) {
             discoveredService->address = QHostAddress(from); // In case we don't receive a A record, use from as address
         }
     } break;
     case MDNS_RECORDTYPE_SRV: {
-        static char auxBuffer[256];
-        mdns_record_srv_t record = mdns_record_parse_srv(data, size, record_offset, record_length, auxBuffer, sizeof(auxBuffer));
+        static char nameBuffer[256];
+        mdns_record_srv_t record = mdns_record_parse_srv(data, size, record_offset, record_length, nameBuffer, sizeof(nameBuffer));
+        // We can use the IP to connect so we don't need to store the "<hostname>.local." address.
+        //discoveredService->qualifiedHostname = QString::fromLatin1(record.name.str, record.name.length);
         discoveredService->port = record.port;
     } break;
     case MDNS_RECORDTYPE_A: {
@@ -88,6 +94,8 @@ static int query_callback(int sock, const struct sockaddr* from, size_t addrlen,
     } break;
     case MDNS_RECORDTYPE_AAAA:
         // Ignore IPv6 for now
+        //sockaddr_in6 addr6;
+        //mdns_record_parse_aaaa(data, size, record_offset, record_length, &addr6);
         break;
     case MDNS_RECORDTYPE_TXT: {
         mdns_record_txt_t records[24];
diff --git a/core/backends/lan/mdns_wrapper.h b/core/backends/lan/mdns_wrapper.h
index ac01fff69..9122d6bed 100644
--- a/core/backends/lan/mdns_wrapper.h
+++ b/core/backends/lan/mdns_wrapper.h
@@ -32,7 +32,7 @@ public:
     int startAnnouncing(const char *hostname, const char *service_name, int service_port);
     void stopAnnouncing();
 
-    void startDiscovering(const char *serviceName);
+    void startDiscovering(const char *serviceType);
     void stopDiscovering();
 
     void sendQuery(const char *serviceName);