From 034ecd24c710e1aa54d21b00d2b4010550ebb2f0 Mon Sep 17 00:00:00 2001 From: Albert Vaca Cintora Date: Sun, 6 Aug 2023 19:48:17 +0000 Subject: [PATCH] Expand comment based on explanation in https://invent.kde.org/network/kdeconnect-kde/-/merge_requests/584 --- indicator/indicatorhelper_mac.cpp | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/indicator/indicatorhelper_mac.cpp b/indicator/indicatorhelper_mac.cpp index d2ab8e9c6..2beddf016 100644 --- a/indicator/indicatorhelper_mac.cpp +++ b/indicator/indicatorhelper_mac.cpp @@ -26,7 +26,9 @@ IndicatorHelper::IndicatorHelper() { registerServices(); - // Do not create QIcon before D-Bus setup, use a QPixmap from a hardcoded icon now + // Use a hardcoded QPixmap because QIcon::fromTheme will instantiate a QPlatformTheme theme + // which could try to use DBus before we have started it and cache an invalid DBus session + // in QDBusConnectionManager const QString iconPath = QStandardPaths::locate(QStandardPaths::AppDataLocation, QStringLiteral("kdeconnect-icons"), QStandardPaths::LocateDirectory); QPixmap splashPixmap(iconPath + QStringLiteral("/hicolor/scalable/apps/kdeconnect.svg")); m_splashScreen = new QSplashScreen(splashPixmap);