tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kdeconnect-kde/kcmplugin/kdeconnectpluginkcm.cpp

23 lines
772 B
C++
Raw Permalink Normal View History

Added a baseclass for the plugins' KCMs and a class for the plugins' config Centralizing the plugins' config will ensure that all the plugins store it the same way (ie: not in random files scattered around, like until now). The base KCM class, together with the already existing base plugin class, will give easy access to all the plugins to this centralized config. Also, now the settings are not shared across devices (that is: every device can have different config for a same plugin). Note: This commit requires KCMUtils 5.9 REVIEW: 122927
2015-03-14 04:19:39 +00:00
/**
Convert license headers to SPDX expressions
2020-08-17 10:48:10 +01:00
* SPDX-FileCopyrightText: 2013 Albert Vaca <albertvaka@gmail.com>
Added a baseclass for the plugins' KCMs and a class for the plugins' config Centralizing the plugins' config will ensure that all the plugins store it the same way (ie: not in random files scattered around, like until now). The base KCM class, together with the already existing base plugin class, will give easy access to all the plugins to this centralized config. Also, now the settings are not shared across devices (that is: every device can have different config for a same plugin). Note: This commit requires KCMUtils 5.9 REVIEW: 122927
2015-03-14 04:19:39 +00:00
*
Convert license headers to SPDX expressions
2020-08-17 10:48:10 +01:00
* SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
Added a baseclass for the plugins' KCMs and a class for the plugins' config Centralizing the plugins' config will ensure that all the plugins store it the same way (ie: not in random files scattered around, like until now). The base KCM class, together with the already existing base plugin class, will give easy access to all the plugins to this centralized config. Also, now the settings are not shared across devices (that is: every device can have different config for a same plugin). Note: This commit requires KCMUtils 5.9 REVIEW: 122927
2015-03-14 04:19:39 +00:00
*/
#include "kdeconnectpluginkcm.h"
Use KPluginMetaData::pluginId for getting config plugin name By removing the postfix we consistently use, we get exactly the same string as before However, all our pluginId logic is now done as part of the buildsystem. Before, they were in the JSON metadata, the buildsystem and the string constructor parameter KPluginFactory has the KPluginMetaData object in any case, do using it doesn't create any overhead.
2023-07-21 11:26:19 +01:00
KdeConnectPluginKcm::KdeConnectPluginKcm(QObject *parent, const KPluginMetaData &data, const QVariantList &args)
Qt6 build fixes in plugins and KCM
2023-04-17 18:10:08 +01:00
#if QT_VERSION_MAJOR < 6
: KCModule(qobject_cast<QWidget *>(parent), args)
#else
: KCModule(parent)
#endif
kcmplugin: Do not use d-ptr for trivial members that are fully qualified Also, make this for the most part header only, because it is just a utility class. We could make this entirely header only, but it is not worth it.
2023-08-12 12:56:19 +01:00
, m_deviceId(args.at(0).toString())
// The plugin name is the KCMs ID with the postfix removed
Fix opening runcommand settings We only get the device id via args, not the plugin id We also don't need it, we can get the plugin id from the metadata
2023-12-13 23:45:39 +00:00
, m_config(new KdeConnectPluginConfig(m_deviceId, data.pluginId().remove(QLatin1String("_config")), this))
Added a baseclass for the plugins' KCMs and a class for the plugins' config Centralizing the plugins' config will ensure that all the plugins store it the same way (ie: not in random files scattered around, like until now). The base KCM class, together with the already existing base plugin class, will give easy access to all the plugins to this centralized config. Also, now the settings are not shared across devices (that is: every device can have different config for a same plugin). Note: This commit requires KCMUtils 5.9 REVIEW: 122927
2015-03-14 04:19:39 +00:00
{
Use KPluginMetaData::pluginId for getting config plugin name By removing the postfix we consistently use, we get exactly the same string as before However, all our pluginId logic is now done as part of the buildsystem. Before, they were in the JSON metadata, the buildsystem and the string constructor parameter KPluginFactory has the KPluginMetaData object in any case, do using it doesn't create any overhead.
2023-07-21 11:26:19 +01:00
Q_ASSERT(data.isValid()); // Even if we have empty metadata, it should be valid!
Added a baseclass for the plugins' KCMs and a class for the plugins' config Centralizing the plugins' config will ensure that all the plugins store it the same way (ie: not in random files scattered around, like until now). The base KCM class, together with the already existing base plugin class, will give easy access to all the plugins to this centralized config. Also, now the settings are not shared across devices (that is: every device can have different config for a same plugin). Note: This commit requires KCMUtils 5.9 REVIEW: 122927
2015-03-14 04:19:39 +00:00
}
Add explicit moc includes to cpp files The rationale is explained in https://planet.kde.org/friedrich-kossebau-2023-06-28-include-also-moc-files-of-headers/ In case of KDEConnect, it impressively speeds up compilation. Before it took 390 seconds on a clean build and with this change it took 330 seconds. This is due to the mocs_compilation having to include the header files and thus all their headers. Due to the lots of small plugins we have, this means that the same headers must be compiled plenty of times. When we include the moc files directly in the C++ file, they are already available.
2023-07-26 09:15:11 +01:00
#include "moc_kdeconnectpluginkcm.cpp"
Reference in a new issue Copy permalink