2013-07-26 15:21:19 +01:00
|
|
|
/**
|
2020-08-17 10:48:10 +01:00
|
|
|
* SPDX-FileCopyrightText: 2013 Albert Vaca <albertvaka@gmail.com>
|
2013-07-26 15:21:19 +01:00
|
|
|
*
|
2020-08-17 10:48:10 +01:00
|
|
|
* SPDX-License-Identifier: GPL-2.0-only OR GPL-3.0-only OR LicenseRef-KDE-Accepted-GPL
|
2013-07-26 15:21:19 +01:00
|
|
|
*/
|
|
|
|
|
2013-08-13 23:03:46 +01:00
|
|
|
#include "batteryplugin.h"
|
2013-07-26 15:21:19 +01:00
|
|
|
|
2013-09-04 20:19:02 +01:00
|
|
|
#include <KLocalizedString>
|
2014-09-22 01:37:10 +01:00
|
|
|
#include <KPluginFactory>
|
2013-07-26 15:21:19 +01:00
|
|
|
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
#include <Solid/Device>
|
|
|
|
#include <Solid/Battery>
|
|
|
|
#include <Solid/Predicate>
|
|
|
|
|
2018-03-18 11:42:15 +00:00
|
|
|
#include <core/daemon.h>
|
|
|
|
|
2013-08-13 23:03:46 +01:00
|
|
|
#include "batterydbusinterface.h"
|
2020-05-26 17:55:47 +01:00
|
|
|
#include "plugin_battery_debug.h"
|
2013-07-26 15:21:19 +01:00
|
|
|
|
2019-06-12 21:16:54 +01:00
|
|
|
K_PLUGIN_CLASS_WITH_JSON(BatteryPlugin, "kdeconnect_battery.json")
|
2013-07-28 21:00:45 +01:00
|
|
|
|
2017-09-03 20:39:44 +01:00
|
|
|
BatteryPlugin::BatteryPlugin(QObject* parent, const QVariantList& args)
|
2013-08-13 23:03:46 +01:00
|
|
|
: KdeConnectPlugin(parent, args)
|
2014-07-01 00:23:21 +01:00
|
|
|
, batteryDbusInterface(new BatteryDbusInterface(device()))
|
2013-08-13 23:03:46 +01:00
|
|
|
{
|
2013-07-28 21:00:45 +01:00
|
|
|
|
2013-08-22 02:21:08 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
void BatteryPlugin::connected()
|
|
|
|
{
|
2020-08-22 16:28:35 +01:00
|
|
|
// We've just connected. Request battery information from the remote device...
|
2019-06-10 15:40:28 +01:00
|
|
|
NetworkPacket np(PACKET_TYPE_BATTERY_REQUEST, {{QStringLiteral("request"),true}});
|
2018-03-04 19:48:51 +00:00
|
|
|
sendPacket(np);
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
|
2020-08-22 16:28:35 +01:00
|
|
|
// ...and then figure out whether we have any batteries
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
const auto batteryDevice = Solid::DeviceInterface::Type::Battery;
|
|
|
|
const auto primary = Solid::Battery::BatteryType::PrimaryBattery;
|
|
|
|
|
|
|
|
QList<Solid::Device> batteries = Solid::Device::listFromQuery(Solid::Predicate(batteryDevice, QStringLiteral("type"), primary));
|
|
|
|
|
|
|
|
if (batteries.isEmpty()) {
|
|
|
|
qCWarning(KDECONNECT_PLUGIN_BATTERY) << "No Primary Battery detected on this system. This may be a bug.";
|
|
|
|
QList<Solid::Device> allBatteries = Solid::Device::listFromType(batteryDevice);
|
|
|
|
qCWarning(KDECONNECT_PLUGIN_BATTERY) << "Total quantity of batteries found: " << allBatteries.size();
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
2020-08-22 16:28:35 +01:00
|
|
|
// Ok, there's at least one. Let's assume it will remain attached (for most laptops
|
|
|
|
// and desktops, this is a safe assumption).
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
const Solid::Battery* chosen = batteries.first().as<Solid::Battery>();
|
|
|
|
|
|
|
|
connect(chosen, &Solid::Battery::chargeStateChanged, this, &BatteryPlugin::chargeChanged);
|
|
|
|
connect(chosen, &Solid::Battery::chargePercentChanged, this, &BatteryPlugin::chargeChanged);
|
|
|
|
|
|
|
|
// Explicitly send the current charge
|
|
|
|
chargeChanged();
|
|
|
|
}
|
|
|
|
|
|
|
|
void BatteryPlugin::chargeChanged()
|
|
|
|
{
|
|
|
|
|
2020-08-22 16:28:35 +01:00
|
|
|
// Note: the NetworkPacket sent at the end of this method can reflect MULTIPLE batteries.
|
|
|
|
// We average the total charge against the total number of batteries, which in practice
|
|
|
|
// seems to work out ok.
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
bool isAnyBatteryCharging = false;
|
|
|
|
int batteryQuantity = 0;
|
|
|
|
int cumulativeCharge = 0;
|
|
|
|
|
|
|
|
const auto batteryDevice = Solid::DeviceInterface::Type::Battery;
|
|
|
|
const auto primary = Solid::Battery::BatteryType::PrimaryBattery;
|
|
|
|
|
|
|
|
QList<Solid::Device> batteries = Solid::Device::listFromQuery(Solid::Predicate(batteryDevice, QStringLiteral("type"), primary));
|
|
|
|
|
|
|
|
for (auto device : batteries) {
|
|
|
|
const Solid::Battery* battery = device.as<Solid::Battery>();
|
|
|
|
|
2020-08-22 16:28:35 +01:00
|
|
|
// Don't look at batteries that can be easily detached
|
|
|
|
if (battery->isPowerSupply()) {
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
batteryQuantity++;
|
|
|
|
cumulativeCharge += battery->chargePercent();
|
|
|
|
if (battery->chargeState() == Solid::Battery::ChargeState::Charging) {
|
|
|
|
isAnyBatteryCharging = true;
|
|
|
|
}
|
|
|
|
}
|
|
|
|
}
|
|
|
|
|
|
|
|
if (batteryQuantity == 0) {
|
|
|
|
qCWarning(KDECONNECT_PLUGIN_BATTERY) << "Primary Battery seems to have been removed. Suspending packets until it is reconnected.";
|
|
|
|
return;
|
|
|
|
}
|
|
|
|
|
|
|
|
// Load a new Battery object to represent the first device in the list
|
|
|
|
Solid::Battery* chosen = batteries.first().as<Solid::Battery>();
|
|
|
|
|
|
|
|
// Prepare an outgoing network packet
|
|
|
|
NetworkPacket status(PACKET_TYPE_BATTERY, {{}});
|
|
|
|
status.set(QStringLiteral("isCharging"), isAnyBatteryCharging);
|
|
|
|
status.set(QStringLiteral("currentCharge"), cumulativeCharge / batteryQuantity);
|
|
|
|
// FIXME: In future, we should consider sending an array of battery objects
|
|
|
|
status.set(QStringLiteral("batteryQuantity"), batteryQuantity);
|
2020-08-22 16:28:35 +01:00
|
|
|
// We consider the primary battery to be low if it won't last another 10 minutes.
|
|
|
|
// This doesn't necessarily work if (for example) Solid finds multiple batteries.
|
|
|
|
// FIXME: In future, we should check system settings instead of hardcoding an
|
|
|
|
// amount of time.
|
|
|
|
if (chosen->timeToEmpty() < 600 && chosen->chargeState() == Solid::Battery::ChargeState::Discharging) {
|
Finally, we have support for sending out Battery information.
## Summary
The core idea is as follows:
1. When a Link loads the BatteryPlugin, we query Solid for a list of batteries.
1. If the list is empty, we print a warning message and return quickly
2. Otherwise, we connect *two signals* to every object in that list
2. We send out a single new NetworkPacket as soon as we've processed that list
3. When either of those two signals emits, we send another new NetworkPacket
### Multi-battery Support
BUG: 357193
To handle devices with multiple batteries (requested in that bug), we average
together the battery percentages. This also includes a new field in the packet for
'number of batteries' called `batteryQuantity`. For backwards compatibility, we can
assume it has a default value of one.
This should ensure we support
- devices with no batteries at all (like many desktop machines)
- devices with hot-pluggable batteries (like those laptops with detachable screens)
### Concerns
Note that the implementation isn't perfect.
We'll need some new localizable text to make it clear that we now support sending
battery status information.
Then there's a rather significant question: maybe we should have two battery plugins
on each client, like we do for the `findmyphone`/`findthisdevice` plugins?
## Test Plan
We need to ensure that other clients (including those using the Android codebase)
will respond correctly. The main things to look at are
1. are these new packets sent when the plugin is enabled, and not sent when it's disabled?
2. is the charge percentage accurate?
3. is the charge state (charging, discharging, or full) accurate?
and
4. do we see the correct number of warnings for low-battery?
2020-04-13 06:54:11 +01:00
|
|
|
status.set(QStringLiteral("thresholdEvent"), (int)ThresholdBatteryLow);
|
|
|
|
} else {
|
|
|
|
status.set(QStringLiteral("thresholdEvent"), (int)ThresholdNone);
|
|
|
|
}
|
|
|
|
sendPacket(status);
|
2013-07-26 15:21:19 +01:00
|
|
|
}
|
|
|
|
|
2013-08-13 23:03:46 +01:00
|
|
|
BatteryPlugin::~BatteryPlugin()
|
2013-07-26 15:21:19 +01:00
|
|
|
{
|
2013-08-14 00:35:12 +01:00
|
|
|
//FIXME: Qt dbus does not allow to remove an adaptor! (it causes a crash in
|
2013-08-20 12:52:25 +01:00
|
|
|
// the next dbus access to its parent). The implication of not deleting this
|
2013-08-14 00:35:12 +01:00
|
|
|
// is that disabling the plugin does not remove the interface (that will
|
|
|
|
// return outdated values) and that enabling it again instantiates a second
|
2013-11-22 18:08:04 +00:00
|
|
|
// adaptor. This is also a memory leak until the entire device is destroyed.
|
2013-08-14 00:35:12 +01:00
|
|
|
|
|
|
|
//batteryDbusInterface->deleteLater();
|
2013-08-13 23:03:46 +01:00
|
|
|
}
|
2013-07-26 15:21:19 +01:00
|
|
|
|
2018-03-04 19:48:51 +00:00
|
|
|
bool BatteryPlugin::receivePacket(const NetworkPacket& np)
|
2013-08-13 23:03:46 +01:00
|
|
|
{
|
2016-11-26 14:38:08 +00:00
|
|
|
bool isCharging = np.get<bool>(QStringLiteral("isCharging"), false);
|
|
|
|
int currentCharge = np.get<int>(QStringLiteral("currentCharge"), -1);
|
|
|
|
int thresholdEvent = np.get<int>(QStringLiteral("thresholdEvent"), (int)ThresholdNone);
|
2013-07-26 15:21:19 +01:00
|
|
|
|
2013-11-18 01:32:42 +00:00
|
|
|
if (batteryDbusInterface->charge() != currentCharge
|
2013-11-14 15:32:16 +00:00
|
|
|
|| batteryDbusInterface->isCharging() != isCharging
|
|
|
|
) {
|
2013-08-13 23:03:46 +01:00
|
|
|
batteryDbusInterface->updateValues(isCharging, currentCharge);
|
2013-11-14 15:32:16 +00:00
|
|
|
}
|
2013-07-26 15:21:19 +01:00
|
|
|
|
2013-11-14 15:32:16 +00:00
|
|
|
if ( thresholdEvent == ThresholdBatteryLow && !isCharging ) {
|
2018-03-18 11:42:15 +00:00
|
|
|
Daemon::instance()->sendSimpleNotification(QStringLiteral("batteryLow"), i18nc("device name: low battery", "%1: Low Battery", device()->name()), i18n("Battery at %1%", currentCharge), QStringLiteral("battery-040"));
|
2013-07-26 15:21:19 +01:00
|
|
|
}
|
|
|
|
|
|
|
|
return true;
|
|
|
|
|
|
|
|
}
|
2013-07-28 21:00:45 +01:00
|
|
|
|
2014-06-16 19:02:07 +01:00
|
|
|
#include "batteryplugin.moc"
|