tristan/kdeconnect-kde
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions
kdeconnect-kde/plugins/sms/kdeconnect_sms.json

42 lines
1.4 KiB
JSON
Raw Normal View History

Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
{
"KPlugin": {
"Authors": [
{
"Email": "simon@ergotech.com",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-11 05:16:50 +01:00
"Name": "Simon Redman",
"Name[x-test]": "xxSimon Redmanxx"
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
}
],
"Description": "Send and receive SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-14 04:48:01 +01:00
"Description[ca@valencia]": "Envia i rep SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-12 05:07:09 +01:00
"Description[ca]": "Envia i rep SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-15 04:55:10 +01:00
"Description[cs]": "Posílat a přijímat SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-18 04:45:43 +01:00
"Description[fr]": "Envoyer et recevoir des SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-12 05:07:09 +01:00
"Description[nl]": "SMS verzenden en ontvangen",
"Description[pt]": "Enviar e receber SMS's",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-13 04:52:26 +01:00
"Description[pt_BR]": "Envia e recebe SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-19 04:53:16 +01:00
"Description[sv]": "Skicka och ta emot SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-12 05:07:09 +01:00
"Description[uk]": "Надсилання і отримання SMS",
"Description[x-test]": "xxSend and receive SMSxx",
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
"EnabledByDefault": true,
Use better icon for SMS plugin
2018-09-12 23:39:26 +01:00
"Icon": "mail-message-new-list",
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
"Id": "kdeconnect_sms",
"License": "GPL",
"Name": "SMS",
SVN_SILENT made messages (.desktop file) - always resolve ours In case of conflict in i18n, keep the version of the branch "ours" To resolve a particular conflict, "git checkout --ours path/to/file.desktop"
2018-09-12 05:07:09 +01:00
"Name[x-test]": "xxSMSxx",
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
"ServiceTypes": [
"KdeConnect/Plugin"
],
"Version": "0.1",
"Website": "https://nicolasfella.wordpress.com"
},
"X-KdeConnect-OutgoingPacketType": [
"kdeconnect.sms.request",
[Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin Summary: Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_* Update TELEPHONY plugin packet description to point to SMS plugin Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field Please see Android-side patch here: D15544 Test Plan: I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision: - New Android vs. New Desktop - Supported and works for me - New Android vs. Old Desktop - Supported and works for me - Old Android vs. New Desktop - Not supported - Download a new app from the Play store or F-Droid - Old Android vs. Old Desktop - If this is broken, it is not my fault :) In the supported use cases: - Test SMS reply - Receive SMS (or MMS!) message - Verify that the //notification// plugin forwards a replyable notification and that replying works - Test incoming call ringer mute - Enable ringer volume (not vibrate) - Receive phone call - Verify a desktop notification with a Mute button appears - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected) Reviewers: #kde_connect, albertvaka, nicolasfella Reviewed By: #kde_connect, albertvaka, nicolasfella Subscribers: nicolasfella, kdeconnect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D15543
2018-09-16 23:03:31 +01:00
"kdeconnect.sms.request_conversations",
"kdeconnect.sms.request_conversation"
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
],
"X-KdeConnect-SupportedPacketType": [
[Desktop] SMS plugin no longer creates desktop notifications -- Old functionality still supported by notifications plugin Summary: Drop support for creating notifications from the SMS plugin. The old usecase is better handled by the notifications plugin reply box anyway Rename packets defined in SMS plugin from PACKET_TYPE_TELEPHONY_* to PACKET_TYPE_SMS_* Update TELEPHONY plugin packet description to point to SMS plugin Define TELEPHONY_REQUEST_MUTE packet to replace old TELEPHONY_REQUEST with mute event field Please see Android-side patch here: D15544 Test Plan: I see four test cases, based on the version of the app being used, where "old" means any version built with sources not containing this revision and "new" means any version built with sources using this revision: - New Android vs. New Desktop - Supported and works for me - New Android vs. Old Desktop - Supported and works for me - Old Android vs. New Desktop - Not supported - Download a new app from the Play store or F-Droid - Old Android vs. Old Desktop - If this is broken, it is not my fault :) In the supported use cases: - Test SMS reply - Receive SMS (or MMS!) message - Verify that the //notification// plugin forwards a replyable notification and that replying works - Test incoming call ringer mute - Enable ringer volume (not vibrate) - Receive phone call - Verify a desktop notification with a Mute button appears - Verify that clicking the mute button causes the phone to stop making the ringer noise (vibration not affected) Reviewers: #kde_connect, albertvaka, nicolasfella Reviewed By: #kde_connect, albertvaka, nicolasfella Subscribers: nicolasfella, kdeconnect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D15543
2018-09-16 23:03:31 +01:00
"kdeconnect.sms.messages"
Split SMS and Telephony plugin on desktop Summary: Telephony and SMS handling are quite distinct so they should be in separate plugins for better maintainability, given that @sredman has big plans with SMS. This diff should be fully backwards compatible, but whether we really want to do that is up to discussion Test Plan: Only supeficially tested. Receive an SMS (old way), Notification is shown Reviewers: #kde_connect, sredman Reviewed By: sredman Subscribers: albertvaka, apol, sredman, kdeconnect, #kde_connect Tags: #kde_connect Differential Revision: https://phabricator.kde.org/D13594
2018-09-10 10:28:54 +01:00
]
}
Reference in a new issue Copy permalink